r260994 - Exclude PCH/missing-file.cpp on Windows, it does not pass reliably

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 16 11:16:28 PST 2016


Author: rnk
Date: Tue Feb 16 13:16:28 2016
New Revision: 260994

URL: http://llvm.org/viewvc/llvm-project?rev=260994&view=rev
Log:
Exclude PCH/missing-file.cpp on Windows, it does not pass reliably

Tag the test with "REQUIRES: can-remove-opened-file", which is what we
use for the similar test Modules/explicit-build-missing-file.cpp.

Modified:
    cfe/trunk/test/PCH/missing-file.cpp

Modified: cfe/trunk/test/PCH/missing-file.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/PCH/missing-file.cpp?rev=260994&r1=260993&r2=260994&view=diff
==============================================================================
--- cfe/trunk/test/PCH/missing-file.cpp (original)
+++ cfe/trunk/test/PCH/missing-file.cpp Tue Feb 16 13:16:28 2016
@@ -4,16 +4,15 @@
 // RUN: echo 'struct S{char c; int i; }; void foo() {}' > %t.h
 // RUN: echo 'template <typename T> void tf() { T::foo(); }' >> %t.h
 // RUN: %clang_cc1 -x c++ -emit-pch -o %t.h.pch %t.h
-
-// %t.h might be touched by scanners as a hot file on Windows,
-// to fail to remove %.h with single run.
-// FIXME: Do we really want to work around bugs in virus checkers here?
-// RUN: rm %t.h || rm %t.h || rm %t.h
+// RUN: rm %t.h
 
 // Check diagnostic with location in original source:
 // RUN: not %clang_cc1 -include-pch %t.h.pch -emit-obj -o %t.o %s 2> %t.stderr
 // RUN: grep 'could not find file' %t.stderr
 
+// Oftentimes on Windows there are open handles, and deletion will fail.
+// REQUIRES: can-remove-opened-file
+
 void qq(S*) {}
 
 #ifdef REDECL




More information about the cfe-commits mailing list