[PATCH] D17299: [ASTReader] Report error when accessing corrupt record data

Vedant Kumar via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 16 11:02:54 PST 2016


vsk created this revision.
vsk added reviewers: rsmith, benlangmuir.
vsk added a subscriber: cfe-commits.

If we try to read a corrupt pch, we can easily assert-fail or trigger invalid
memory accesses when manipulating ASTReader::RecordData objects. This problem
is easy enough to diagnose when assertions are enabled, but can cause trouble
otherwise.

Emit an error diagnostic when we detect a bad RecordData access.

http://reviews.llvm.org/D17299

Files:
  include/clang/Serialization/ASTReader.h
  lib/Serialization/ASTReader.cpp
  lib/Serialization/ASTReaderDecl.cpp
  lib/Serialization/ASTReaderStmt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17299.48086.patch
Type: text/x-patch
Size: 9197 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160216/3374fa28/attachment.bin>


More information about the cfe-commits mailing list