[libcxx] r260961 - Issue a warning instead of fatal errors when checks for libatomic fail.

Vasileios Kalintiris via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 16 06:15:27 PST 2016


Author: vkalintiris
Date: Tue Feb 16 08:15:27 2016
New Revision: 260961

URL: http://llvm.org/viewvc/llvm-project?rev=260961&view=rev
Log:
Issue a warning instead of fatal errors when checks for libatomic fail.

This should fix PR26631, PR26622 and has the nice property that the addition
of the CheckLibcxxAtomic.cmake module acts as an NFC on the platforms of the
reporters (at least for the time being).

As these bug reports explain, CMake fails the atomic check because the
include headers might not exist in the host environment. We could
potentially point to the headers provided by libcxx itself.

Modified:
    libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake

Modified: libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake?rev=260961&r1=260960&r2=260961&view=diff
==============================================================================
--- libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake (original)
+++ libcxx/trunk/cmake/Modules/CheckLibcxxAtomic.cmake Tue Feb 16 08:15:27 2016
@@ -33,9 +33,9 @@ if(NOT LIBCXX_HAVE_CXX_ATOMICS_WITHOUT_L
     list(APPEND CMAKE_REQUIRED_LIBRARIES "atomic")
     check_cxx_atomics(LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB)
     if (NOT LIBCXX_HAVE_CXX_ATOMICS_WITH_LIB)
-      message(FATAL_ERROR "Host compiler must support std::atomic!")
+      message(WARNING "Host compiler must support std::atomic!")
     endif()
   else()
-    message(FATAL_ERROR "Host compiler appears to require libatomic, but cannot find it.")
+    message(WARNING "Host compiler appears to require libatomic, but cannot find it.")
   endif()
 endif()




More information about the cfe-commits mailing list