[PATCH] D17253: Cleanup of analyzer scripts as suggested by pychecker and pep8

Anna Zaks via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 15 14:50:35 PST 2016


zaks.anna added a comment.

Please, test these changes.

Thanks!
Anna.


================
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/CmpRuns.py:31
@@ -30,3 +30,3 @@
 import plistlib
-import CmpRuns
+import CmpRuns  # ?
 
----------------
ariccio wrote:
> This file imports itself?
> 
> I wasn't sure if I could eliminate this.
Might be left over from refactoring.

================
Comment at: C:/LLVM/llvm/tools/clang/utils/analyzer/SATestBuild.py:521
@@ -502,3 +520,3 @@
             SummaryLog.write("See the first %d below.\n"
-                                                   % (NumOfFailuresInSummary,))
+                             (NumOfFailuresInSummary,))
         # TODO: Add a line "See the results folder for more."
----------------
Is removing '%' correct here?


http://reviews.llvm.org/D17253





More information about the cfe-commits mailing list