[PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

Louis Dionne via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 15 14:10:00 PST 2016


ldionne updated this revision to Diff 48012.
ldionne added a comment.

Address some remaining issues:

- Rename __nth_element to __type_pack_element, as suggested by Richard Smith
- Fix template parameter position issue in createTypePackElementParameterList

AFAICT, the only remaining issue is whether we should produce a diagnostic when the index is out of bounds, or whether this is reserved for standard diagnostics and we should use another mean to report the error. This is a trivial issue and I'll fix it or remove the TODO as soon as someone tells me the right way to go.

I'm really hoping that we can move forward with this patch.


http://reviews.llvm.org/D15421

Files:
  include/clang/AST/ASTContext.h
  include/clang/AST/DeclTemplate.h
  include/clang/Basic/Builtins.h
  include/clang/Basic/DiagnosticSemaKinds.td
  include/clang/Serialization/ASTBitCodes.h
  lib/AST/ASTContext.cpp
  lib/AST/DeclTemplate.cpp
  lib/Lex/PPMacroExpansion.cpp
  lib/Sema/SemaLookup.cpp
  lib/Sema/SemaTemplate.cpp
  lib/Serialization/ASTReader.cpp
  lib/Serialization/ASTWriter.cpp
  test/PCH/type_pack_element.cpp
  test/SemaCXX/type_pack_element.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15421.48012.patch
Type: text/x-patch
Size: 15010 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160215/8fc013e5/attachment-0001.bin>


More information about the cfe-commits mailing list