[PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

[Manman Ren via cfe-commits]

manmanren added a comment.

Thanks for working on this!

Manman


================
Comment at: lib/Sema/TypeLocBuilder.cpp:99
@@ +98,3 @@
+    // element was pushed.
+    RemoveOrInsertPadding = NumBytesAtAlign4 != 0;
+  }
----------------
This patch seems to do two things:
1> simplify the logic of deciding when to remove padding and when to insert padding (via RemoveOrInsertPadding)
2> fix the correctness issue

We can fix the correctness issue first and then simplify the logic.



http://reviews.llvm.org/D16843