[PATCH] D17166: [Sema] More changes to fix Objective-C fallout from r249995.

George Burgess IV via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 11 14:36:40 PST 2016


george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

Sorry that the change to overload resolution turned out to be problematic. :)

One nit, and this LGTM.


================
Comment at: lib/Sema/SemaExpr.cpp:7580
@@ +7579,3 @@
+      if (Diagnose) {
+        // If an error was diagnosed here, replace the expression with a
+        // corrected version and continue so we can find further errors.
----------------
Because we're doing a similar thing at line 7573 (not necessarily replacing an expression, but still answering differently depending on the value of `Diagnose`), can we either put a similar comment there, or make this comment a bit more general and move it above `if (getLangOpts().ObjCAutoRefCount && [...]`?


http://reviews.llvm.org/D17166





More information about the cfe-commits mailing list