r252114 - [modules] If we're given a module file, via -fmodule-file=, for a module, but

Adrian Prantl via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 11 11:46:51 PST 2016


> On Feb 11, 2016, at 11:04 AM, Ben Langmuir <blangmuir at apple.com> wrote:
> 
> FYI I changed this to early-exit again in r260563 to fix implicit builds.  It’s not safe to keep reading if we haven’t told ReadOptionsBlock to expect failures, since it will itself early-exit, leaving the stream in the middle of a block.  It’s also a performance advantage to early exit when doing implicit builds.
> 
> Ben

Thanks, Ben!

-- adrian


More information about the cfe-commits mailing list