[PATCH] D17104: [VFS] Drop path traversal assertion

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 15:14:35 PST 2016


benlangmuir added a comment.

I don't think this is the right approach.  If we don't canonicalize the source path then:

- looking up the path *without* the .. won't work, which means anything that looks up a realpath will fail
- directory iteration won't combine entries from foo/bar/.. and foo/

I think we're better off handling ".." in lookup and always using canonicalized paths in the YAML representation.


http://reviews.llvm.org/D17104





More information about the cfe-commits mailing list