[libcxx] r260012 - Cleanup node-type handling in the unordered containers

Bob Wilson via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 13:25:33 PST 2016


> On Feb 10, 2016, at 12:59 PM, Tim Northover <t.p.northover at gmail.com> wrote:
> 
> On 10 February 2016 at 12:52, Eric Fiselier <eric at efcs.ca> wrote:
>> @Tim Are these tests in the clang test suite?
> 
> Yep, at http://llvm.org/git/test-suite.git.
> 
>> Marshall and I were just talking about removing <ext/hash_map> all together. Could you explain who still uses it?
> 
> In the test-suite, it looks like it's just these two micro-benchmarks.
> I doubt anyone would complain about converting them to use
> std::unordered_map (especially since the underlying implementation
> seems to be shared anyway).
> 
> Outside that, we seem to have a handful of internal users and Bob may
> have ABI backwards-compatibility concerns (or not). I've added him
> explicitly.

I will defer to Duncan on that question.


More information about the cfe-commits mailing list