[PATCH] D17072: Return immediatedly if Method is null, otherwise you'll get a crash when dyn_cast is called with a nullptr

[David Majnemer via cfe-commits]

This needs a testcase added to the tests directory.

On Wednesday, February 10, 2016, don hinton via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> hintonda created this revision.
> hintonda added reviewers: doug.gregor, rnk.
> hintonda added a subscriber: cfe-commits.
>
> Fixes crash referenced in PR25181 where dyn_cast is called on a null
> instance of LM.Method.
>
> http://reviews.llvm.org/D17072
>
> Files:
>   lib/Parse/ParseCXXInlineMethods.cpp
>
> Index: lib/Parse/ParseCXXInlineMethods.cpp
> ===================================================================
> --- lib/Parse/ParseCXXInlineMethods.cpp
> +++ lib/Parse/ParseCXXInlineMethods.cpp
> @@ -293,6 +293,7 @@
>  }
>
>  void Parser::ParseLexedMethodDeclaration(LateParsedMethodDeclaration &LM)
> {
> +  if(!LM.Method) return;


Please format this line with clang-format.


>    // If this is a member template, introduce the template parameter scope.
>    ParseScope TemplateScope(this, Scope::TemplateParamScope,
> LM.TemplateScope);
>    TemplateParameterDepthRAII
> CurTemplateDepthTracker(TemplateParameterDepth);
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160210/7182737b/attachment.html>