[PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

[Romanova, Katya via cfe-commits]

My apologies…

From: David Blaikie [mailto:dblaikie at gmail.com]
Sent: Tuesday, February 09, 2016 4:42 PM
To: reviews+D17021+public+89c4dbb2f75e8fba at reviews.llvm.org; Romanova, Katya
Cc: Gao, Yunzhong; Robinson, Paul; Eric Christopher; Dmitri Gribenko; Craig Topper; Jonathan Roelofs; cfe-commits
Subject: Re: [PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

It's best not to commit things without approval once they've been sent for review (the assumption being that if you asked for review it's because the change needed review - time doesn't change that fact) - if approval was given off-list (eg: on IRC) it's best to mention who gave it & where (& ideally the person should provide it on-list just for record keeping)

On Tue, Feb 9, 2016 at 4:16 PM, Katya Romanova via cfe-commits <cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>> wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260333: This patch adds doxygen comments for all the intrinsincs in the header file… (authored by kromanova).

Changed prior to commit:
  http://reviews.llvm.org/D17021?vs=47299&id=47394#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D17021

Files:
  cfe/trunk/lib/Headers/f16cintrin.h


_______________________________________________
cfe-commits mailing list
cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160210/b1c9452b/attachment-0001.html>