[PATCH] D16310: new clang-tidy checker misc-long-cast

Daniel Marjamäki via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 00:42:28 PST 2016


danielmarjamaki added inline comments.

================
Comment at: clang-tools-extra/trunk/clang-tidy/misc/MisplacedWideningCastCheck.cpp:21-23
@@ +20,5 @@
+void MisplacedWideningCastCheck::registerMatchers(MatchFinder *Finder) {
+  auto Calc = expr(anyOf(binaryOperator(anyOf(
+                             hasOperatorName("+"), hasOperatorName("-"),
+                             hasOperatorName("*"), hasOperatorName("<<"))),
+                         unaryOperator(hasOperatorName("~"))),
----------------
LegalizeAdulthood wrote:
> Sorry for the late observation, but why doesn't this check for `%` and `/` operators?
That is intentional.. you can't get overflow with / , % , & , | , etc...


Repository:
  rL LLVM

http://reviews.llvm.org/D16310





More information about the cfe-commits mailing list