SV: [PATCH] D16310: new clang-tidy checker misc-long-cast

[Daniel Marjamäki via cfe-commits]

That is intentional.. you can't get overflow with / , % , & , | , etc...

..................................................................................................................
Daniel Marjamäki Senior Engineer
Evidente ES East AB  Warfvinges väg 34  SE-112 51 Stockholm  Sweden

Mobile:                 +46 (0)709 12 42 62
E-mail:                 Daniel.Marjamaki at evidente.se

www.evidente.se

________________________________________
Från: Richard [legalize at xmission.com]
Skickat: den 10 februari 2016 07:28
Till: Daniel Marjamäki; aaron.ballman at gmail.com; alexfh at google.com
Kopia: legalize at xmission.com; eugene.zelenko at gmail.com; cfe-commits at lists.llvm.org
Ämne: Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

LegalizeAdulthood added inline comments.

================
Comment at: clang-tools-extra/trunk/clang-tidy/misc/MisplacedWideningCastCheck.cpp:21-23
@@ +20,5 @@
+void MisplacedWideningCastCheck::registerMatchers(MatchFinder *Finder) {
+  auto Calc = expr(anyOf(binaryOperator(anyOf(
+                             hasOperatorName("+"), hasOperatorName("-"),
+                             hasOperatorName("*"), hasOperatorName("<<"))),
+                         unaryOperator(hasOperatorName("~"))),
----------------
Sorry for the late observation, but why doesn't this check for `%` and `/` operators?


Repository:
  rL LLVM

http://reviews.llvm.org/D16310