[PATCH] D16308: clang-tidy Enhance readability-simplify-boolean-expr check to handle implicit conversions of integral types to bool and member pointers

[Richard via cfe-commits]

[Please reply *only* to the list and do not include my email directly
in the To: or Cc: of your reply; otherwise I will not see your reply.
Thanks.]

In article <E1aTA3p-0002aM-4v at shell.xmission.com>,
    Richard via cfe-commits <cfe-commits at lists.llvm.org> writes:

> make check-all passes for me.  I don't see what the problem is in the logs
> either.

OK, I found the problem.  Once again, StringRef bites me on the behind.

I have updated the review in phabricator with the corrected code.
(The review was closed, so apparently it didn't post to the list
when I updated it on phabricator?)

I surmised that the buildbots do a release build and when I did
check-clang-tools in release, I was able to reproduce the failure.
clang-tidy seg-faults.

It would be nice if we could get the build log output to record that
fact in the log.  I suspect it is the way that clang-tidy is invoked
by the check_clang_tidy.py python script.  Somehow the offending SEGV
message is suppressed.
-- 
"The Direct3D Graphics Pipeline" free book <http://tinyurl.com/d3d-pipeline>
     The Computer Graphics Museum <http://ComputerGraphicsMuseum.org>
         The Terminals Wiki <http://terminals.classiccmp.org>
  Legalize Adulthood! (my blog) <http://LegalizeAdulthood.wordpress.com>