[PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

Devin Coughlin via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 9 18:26:59 PST 2016


dcoughlin updated this revision to Diff 47412.
dcoughlin added a comment.

Updated this to address Anna's comments.

- I've made the state smaller. It is just now a set of SymbolRefs for methods instances that have been dealloc'd.
- I've hoisted isSuperDeallocMessage() to early return when possible.
- I've added tests with -analyzer-output=text.
- I've moved the lazy initialization of the dealloc selector identifier to isSuperDeallocMessage()


http://reviews.llvm.org/D5238

Files:
  lib/StaticAnalyzer/Checkers/CMakeLists.txt
  lib/StaticAnalyzer/Checkers/Checkers.td
  lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp
  test/Analysis/DeallocUseAfterFreeErrors.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5238.47412.patch
Type: text/x-patch
Size: 15532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160210/ab490659/attachment-0001.bin>


More information about the cfe-commits mailing list