[PATCH] D17051: Get rid of CHECK-SAME-NOT in tests.

[Justin Lebar via cfe-commits]

jlebar marked 2 inline comments as done.

================
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
 // RUN: cat %t-mod.ll | FileCheck %s
 // RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
 
----------------
jroelofs wrote:
> jlebar wrote:
> > jlebar wrote:
> > > jlebar wrote:
> > > > jroelofs wrote:
> > > > > While you're here, may as well shorten these three lines to:
> > > > > 
> > > > > 
> > > > > ```
> > > > > // RUN: %clang_cc1 -triple %itanium_abi_triple -x objective-c++ -std=c++11 -debug-info-kind=limited -fmodules -fmodule-format=obj -fimplicit-module-maps -DMODULES -fmodules-cache-path=%t %s -I %S/Inputs -I %t -emit-llvm -o %t.ll -mllvm -debug-only=pchcontainer | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-NEG
> > > > > ```
> > > > > 
> > > > > (as long as you also move the one CHECK-NEG-NOT line up before all of the other `CHECK` lines)
> > > > I don't think that means the same thing?  CHECK-NOT: foo checks that "foo" does not appear between the last match (or the beginning of the file, if there was no last match) *and the next match*.
> > > Oh, I see, it's CHECK-NEG-NOT, so there are no other instances of CHECK-NEG, it's fine how you say.  I'll change it, sure.
> > Actually, if you don't mind, I'd rather do that in a separate patch, in case it breaks something.  I'll send you a patch in a sec.
> I don't mind.
OK, this is not so simple (or else, perhaps, it's I who is simple).  The output is sometimes empty, which makes FileCheck unhappy, and I don't even know what else is going on.  I've spent 20 minutes on this now, which I think is a fair penalty for stirring this pot.  :)  Feel free to send me a review.


http://reviews.llvm.org/D17051