[PATCH] D17002: [lanai] Add Lanai backend to clang driver

[Eli Bendersky via cfe-commits]

eliben added a subscriber: eliben.
eliben added a comment.

Clang-level tests?


================
Comment at: lib/Basic/Targets.cpp:5873
@@ +5872,3 @@
+        "-m:e"      // ELF name manging
+        "-p:32:32"  // 32-bit pointers work aligned
+        "-i64:64"   // 64 bit integers, 64 bit aligned
----------------
Maybe make this consistent with the next line comment?

================
Comment at: lib/CodeGen/TargetInfo.cpp:6498
@@ +6497,3 @@
+
+  unsigned DefaultNumRegisterParameters;
+
----------------
Worth a comment? (I dont see thsi documented elsewhere)

================
Comment at: lib/CodeGen/TargetInfo.cpp:6535
@@ +6534,3 @@
+  const Type *T = isSingleElementStruct(Ty, getContext());
+  if (!T)
+    T = Ty.getTypePtr();
----------------
Prefer nullptr comparison (here and elsewhere)


http://reviews.llvm.org/D17002