r260270 - [PGO] Fix issue: explicitly defaulted assignop is not profiled
Xinliang David Li via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 9 12:03:00 PST 2016
Author: davidxl
Date: Tue Feb 9 14:02:59 2016
New Revision: 260270
URL: http://llvm.org/viewvc/llvm-project?rev=260270&view=rev
Log:
[PGO] Fix issue: explicitly defaulted assignop is not profiled
Differential Revision: http://reviews.llvm.org/D16947
Added:
cfe/trunk/test/Profile/def-assignop.cpp
Modified:
cfe/trunk/lib/CodeGen/CGClass.cpp
Modified: cfe/trunk/lib/CodeGen/CGClass.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGClass.cpp?rev=260270&r1=260269&r2=260270&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGClass.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGClass.cpp Tue Feb 9 14:02:59 2016
@@ -1608,6 +1608,7 @@ void CodeGenFunction::emitImplicitAssign
LexicalScope Scope(*this, RootCS->getSourceRange());
+ incrementProfileCounter(RootCS);
AssignmentMemcpyizer AM(*this, AssignOp, Args);
for (auto *I : RootCS->body())
AM.emitAssignment(I);
Added: cfe/trunk/test/Profile/def-assignop.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Profile/def-assignop.cpp?rev=260270&view=auto
==============================================================================
--- cfe/trunk/test/Profile/def-assignop.cpp (added)
+++ cfe/trunk/test/Profile/def-assignop.cpp Tue Feb 9 14:02:59 2016
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -x c++ -std=c++11 %s -triple x86_64-unknown-linux-gnu -main-file-name def-assignop.cpp -o - -emit-llvm -fprofile-instrument=clang | FileCheck --check-prefix=PGOGEN %s
+// RUN: %clang_cc1 -x c++ -std=c++11 %s -triple x86_64-unknown-linux-gnu -main-file-name def-assignop.cpp -o - -emit-llvm -fprofile-instrument=clang -fcoverage-mapping | FileCheck --check-prefix=COVMAP %s
+
+struct B {
+ B& operator=(const B &b);
+ B& operator=(const B &&b);
+};
+
+struct A {
+ A &operator=(const A &) = default;
+ // PGOGEN: define {{.*}}@_ZN1AaSERKS_(
+ // PGOGEN: %pgocount = load {{.*}} @__profc__ZN1AaSERKS_
+ // PGOGEN: {{.*}}add{{.*}}%pgocount, 1
+ // PGOGEN: store{{.*}}@__profc__ZN1AaSERKS_
+ A &operator=(A &&) = default;
+ // PGOGEN: define {{.*}}@_ZN1AaSEOS_
+ // PGOGEN: %pgocount = load {{.*}} @__profc__ZN1AaSEOS_
+ // PGOGEN: {{.*}}add{{.*}}%pgocount, 1
+ // PGOGEN: store{{.*}}@__profc__ZN1AaSEOS_
+
+ // Check that coverage mapping includes 6 function records including the
+ // defaulted copy and move operators: A::operator=
+ // COVMAP: @__llvm_coverage_mapping = {{.*}} { { i32, i32, i32, i32 }, [3 x <{{.*}}>],
+ B b;
+};
+
+int main() {
+ A a1, a2;
+ a1 = a2;
+ a2 = static_cast<A &&>(a1);
+ return 0;
+}
More information about the cfe-commits
mailing list