[PATCH] D17021: Adding doxygen comments to the LLVM intrinsics (part 5, f16cintrin.h)

[Katya Romanova via cfe-commits]

kromanova created this revision.
kromanova added reviewers: ygao, probinson, echristo, gribozavr, craig.topper, jroelofs.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.

Eric Christopher told me that from now on it's OK to commit doxygen comments for x86 intrinsics without formal OK from the open source reviewers.  Post-commit reviews could be done later if needed. It should speed up the process.

I still think it's worth posting a code review. At first, it's nice for bookkeeping. At second, I made one tiny non-comment related change by replacing the name of the parameter in one of the intrinsics. It's done for consistency purpose. It might be the only thing that needs to be briefly looked at during pre-commit review.

=================================================================
Here is the patch with the doxygen comments for the intrinsincs in the header file f16cintrin.h.
The doxygen comments are automatically generated based on SCE internal intrinsics document using DCG tool that I wrote.

I will submit more doxygen comments for the other intrinsic header files as soon as this patch is approved.

Here is the link to the general discussion about adding comments to x86 intrinsics headers.
http://permalink.gmane.org/gmane.comp.compilers.clang.devel/42032

Here are the links to the similar code reviews for the doxygen comments other header files.

http://reviews.llvm.org/D8762 (closed)
http://reviews.llvm.org/D15999 (closed)
http://reviews.llvm.org/D16562 (closed)
http://reviews.llvm.org/D16913 (closed)


Repository:
  rL LLVM

http://reviews.llvm.org/D17021

Files:
  f16cintrin.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17021.47299.patch
Type: text/x-patch
Size: 3349 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160209/80e4845f/attachment.bin>