r260124 - Remove dead code.

[Vassil Vassilev via cfe-commits]

On 08/02/16 20:10, Richard Smith via cfe-commits wrote:
> Author: rsmith
> Date: Mon Feb  8 13:10:14 2016
> New Revision: 260124
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260124&view=rev
> Log:
> Remove dead code.
>
> Modified:
>      cfe/trunk/lib/Sema/SemaLookup.cpp
>
> Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaLookup.cpp?rev=260124&r1=260123&r2=260124&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Sema/SemaLookup.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaLookup.cpp Mon Feb  8 13:10:14 2016
> @@ -432,10 +432,6 @@ static bool isPreferredLookupResult(Sema
>       if (Prev == EUnderlying)
>         return true;
>     return false;
> -
> -  // If the existing declaration is hidden, prefer the new one. Otherwise,
> -  // keep what we've got.
> -  return !S.isVisible(Existing);
Shouldn't we generally prefer the new D if the Existing is hidden?
>   }
>   
>   /// Determine whether \p D can hide a tag declaration.
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits