[PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0
Xiuli PAN via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 5 19:00:56 PST 2016
pxli168 added inline comments.
================
Comment at: lib/Sema/SemaDecl.cpp:13011
@@ -12978,5 +13010,3 @@
- // OpenCL 1.2 spec, s6.9 r:
- // The event type cannot be used to declare a structure or union field.
- if (LangOpts.OpenCL && T->isEventT()) {
- Diag(Loc, diag::err_event_t_struct_field);
+ // OpenCL v1.2 s6.9b,r & OpenCL v2.0 s6.12.5 - The following types can be used
+ // as structure or union field: image, sampler, event or block types.
----------------
can -> cannot
I just find I could not understand this.
================
Comment at: lib/Sema/SemaType.cpp:3827
@@ +3826,3 @@
+ if (LangOpts.OpenCL) {
+ // OpenCL v1.2 s6.9 doesn't support variadic functions, except for
+ // printf
----------------
OpenCL v1.2 s6.9 doesn't support variadic functions, except for ->OpenCL v1.2 s6.9 - Variadic functions are not supported, ....
Repository:
rL LLVM
http://reviews.llvm.org/D16928
More information about the cfe-commits
mailing list