[PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia Stulova via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 5 07:50:54 PST 2016


Anastasia added inline comments.

================
Comment at: lib/Parse/ParseStmt.cpp:2214
@@ +2213,3 @@
+
+bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &Attrs) {
+  MaybeParseGNUAttributes(Attrs);
----------------
pxli168 wrote:
> I am wondering where should this function goes in, here or ParseDecl.cpp.
ParseGNUAttributes is in ParseDecl.cpp, but may be because it's generally applicable to Decls?

I am not aware of any rule here.


http://reviews.llvm.org/D16686





More information about the cfe-commits mailing list