[PATCH] D16784: [OpenMP] Reorganize code to allow specialized code generation for different devices.

Alexey Bataev via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 4 11:59:29 PST 2016


ABataev added inline comments.

================
Comment at: lib/Frontend/CompilerInvocation.cpp:1837
@@ +1836,3 @@
+      Diags.Report(clang::diag::err_drv_omp_host_or_device_target_not_supported)
+          << TargetOpts.Triple << /*Device=*/false;
+      break;
----------------
No, I mean do we really need this argument if this is a constant? I think for now we should just throw it away and edit error message so that it does not expect the second argument,


http://reviews.llvm.org/D16784





More information about the cfe-commits mailing list