[PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 4 04:55:10 PST 2016


hokein marked 3 inline comments as done.

================
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:51
@@ +50,3 @@
+  HeaderFileExtensions.clear();
+  for (llvm::StringRef Suffix : Suffixes) {
+    llvm::StringRef Extension = Suffix.trim();
----------------
Thanks for the explanation.
Now I add `delimiter` parameter to this function to allow developers to set specified character.
 

================
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.h:34
@@ +33,3 @@
+bool isPresumedLocInHeaderFile(
+    SourceLocation Loc, SourceManager &SM,
+    const HeaderFileExtensionsSet &HeaderFileExtensions);
----------------
It is used in `UnnamedNamespaceInHeaderCheck`.


http://reviews.llvm.org/D16113





More information about the cfe-commits mailing list