[PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

[Hubert Tong via cfe-commits]

hubert.reinterpretcast added a comment.

Minor comments; otherwise, LGTM.


================
Comment at: lib/Sema/SemaDecl.cpp:6007
@@ +6006,3 @@
+      // applied only to the definition of a [...] variable template, declared
+      // in namespace scope. [...] A concept definition refers to [...] a
+      // variable concept and its initializer.
----------------
We do not need to quote the second sentence here. The ellipsis in the first sentence should be expanded since the full list is necessary to conclude that the cases being diagnosed here are excluded.

================
Comment at: lib/Sema/SemaDecl.cpp:7754
@@ +7753,3 @@
+      // in namespace scope. [...] A concept definition refers to either a
+      // function concept and its definition [...].
+      if (isFunctionTemplateSpecialization) {
----------------
We do not need to quote the second sentence here. The ellipsis in the first sentence should be expanded since the full list is necessary to conclude that the cases being diagnosed here are excluded.


http://reviews.llvm.org/D13357