[PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Richard via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 3 16:46:51 PST 2016


LegalizeAdulthood added a comment.

In http://reviews.llvm.org/D16794#341552, @aaron.ballman wrote:

> Missing a test case for this functionality. The isExpansionInMainFile() was used to silence the diagnostic in macros, but it was pointed out during review that this should be fixed and it seems to have fallen through the cracks. Can you also add tests for macros to ensure the behavior is acceptable there still?
>
> See http://reviews.llvm.org/D8996 for more context.


It hasn't fallen through the cracks, I've been having an offline discussion with Alexander Kornienko about how to get automated checks to work for fixits applied to headers.


Repository:
  rL LLVM

http://reviews.llvm.org/D16794





More information about the cfe-commits mailing list