[PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

Evgeniy Stepanov via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 3 11:38:46 PST 2016


eugenis added inline comments.

================
Comment at: lib/CodeGen/CGClass.cpp:2608
@@ -2607,3 +2607,3 @@
   auto TypeId = CGM.CreateCfiIdForTypeMetadata(MD);
   if (CGM.getCodeGenOpts().SanitizeCfiCrossDso && TypeId) {
     EmitCfiSlowPathCheck(M, BitSetTest, TypeId, CastedVTable, StaticData);
----------------
samsonov wrote:
> Can we rewrite this as if-elseif-else block now?
even better, with 2 early returns.


Repository:
  rL LLVM

http://reviews.llvm.org/D16823





More information about the cfe-commits mailing list