[PATCH] D16638: [CUDA] Added device-side system call decls and related wrappers.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 3 10:58:00 PST 2016


jlebar added a comment.

lg with one question about printf.


================
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:237
@@ +236,3 @@
+// device-side declaration for it.
+__device__ int printf(const char *, ...);
+} // extern "C"
----------------
I think we want an attribute on this so that we know it's printf-like, so you get appropriate format-string warnings.  Unless the compiler is going to add said attribute automatically based on the just the function name.


http://reviews.llvm.org/D16638





More information about the cfe-commits mailing list