[PATCH] D16376: clang-tidy check: rule-of-five

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 3 06:09:10 PST 2016


alexfh added a comment.

In http://reviews.llvm.org/D16376#342901, @jbcoe wrote:

> I think I'll move this check to `cppcoreguidelines` and call it `rule-of-five`.


Yes, please move it to cppcoreguidelines.

> https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all


Please use anchors defined in the .md file. They are somewhat stable unlike the automatic anchors generated by github (which have changed at least once since first C++ Core Guidelines checks were committed). For the rule of five this would be https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rc-five

> I'll add destructor handling as a later patch.


SG


http://reviews.llvm.org/D16376





More information about the cfe-commits mailing list