[PATCH] D16823: [cfi] Safe handling of unaddressable vtable pointers (clang).

Alexey Samsonov via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 2 14:33:14 PST 2016


samsonov added a subscriber: samsonov.

================
Comment at: lib/CodeGen/CGExpr.cpp:2494
@@ +2493,3 @@
+  llvm::Value *ValidVtable = nullptr;
+  if (CheckAndAppendValidVtable) {
+    llvm::Value *AllVtables = llvm::MetadataAsValue::get(
----------------
This is really ugly. Why are you not passing it down in DynamicArgs? Is it performance penalty you don't want to pay if the check will not succeed? How large will it be?


Repository:
  rL LLVM

http://reviews.llvm.org/D16823





More information about the cfe-commits mailing list