[PATCH] D16135: Macro Debug Info support in Clang

Adrian Prantl via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 1 09:43:26 PST 2016


aprantl added inline comments.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:2099
@@ -2098,1 +2098,3 @@
 
+llvm::DIMacro *CGDebugInfo::CreateMacro(llvm::DIMacroFile *Parent, bool IsUndef,
+                                        SourceLocation LineLoc, StringRef Name,
----------------
By using a bool for IsUndef, we'll end up with somewhat ugly call sites like  
  DI->CreateMacro(Parent, /*IsUndef*/ true, ...);
so we might as well just pass in the dwarf constant
  DI->CreateMacro(Parent, llvm::dwarf::DW_MACINFO_undef, ...);
directly.


http://reviews.llvm.org/D16135





More information about the cfe-commits mailing list