[PATCH] D16692: [OpenCL] Eliminate warning when declaring OpenCL builtin functions

[Anastasia Stulova via cfe-commits]

Anastasia added inline comments.

================
Comment at: lib/Sema/SemaLookup.cpp:698
@@ +697,3 @@
+        // tgmath.h, time.h, wchar.h and wctype.h are not available and cannot
+        // be included by a program.
+        if (S.getLangOpts().OpenCL &&
----------------
pxli168 wrote:
> I think the  
> > C99 standard headers
> can cover those
> > ...
> >  // ctype.h, complex.h, errno.h, fenv.h, float.h, inttypes.h, limits.h,
> >  // locale.h, setjmp.h, signal.h, stdarg.h, stdio.h, stdlib.h, string.h,
> >  // tgmath.h, time.h, wchar.h and wctype.h
> The comment shuold not be copy and paste as Anastasia will say.
> 
Absolutely! Just a reference to the section in spec and a short summary sentence should be enough.

However, could we also combine this with CPP comment above (see another comment).

================
Comment at: lib/Sema/SemaLookup.cpp:699
@@ +698,3 @@
+        // be included by a program.
+        if (S.getLangOpts().OpenCL &&
+            S.Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID))
----------------
I think we could combine this with the CPP check above?


http://reviews.llvm.org/D16692