[PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 28 16:09:29 PST 2016


Do you have a script that will take as input a commit range and git
commit --amend clang-tidy fixes for lines modified in that range?
Because if so,

a) I would be your best friend forever, and
b) It should be simple to convert that into a linter for arc to catch
the case when I forget to run said tool.

On Thu, Jan 28, 2016 at 4:06 PM, Eric Christopher <echristo at gmail.com> wrote:
> echristo added inline comments.
>
> ================
> Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
> @@ +86,3 @@
> +  // Construct and fill the args buffer that we'll pass to vprintf.
> +  llvm::Value* BufferPtr;
> +  if (Args.size() <= 1) {
> ----------------
> jlebar wrote:
>> echristo wrote:
>> > * on the wrong side ;)
>> Argh, I really need to set up a linter.  I'm still doing readability reviews, and I cannot brain two styles.  Sorry to keep wasting your time with silly stuff like this.
> You could just use clang-format on everything :)
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D16664
>
>
>


More information about the cfe-commits mailing list