[PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

[Artem Belevich via cfe-commits]

tra added inline comments.

================
Comment at: include/clang/Driver/Options.td:1807
@@ +1806,3 @@
+    "CUDA compilation without --save-temps.">;
+def nostop_on_failure : Flag<["-"], "nostop-on-failure">, Flags<[DriverOption]>;
+
----------------
I'd use 'no-' prefix.

================
Comment at: lib/Driver/Driver.cpp:650
@@ -638,3 +649,3 @@
   SmallVector<std::pair<int, const Command *>, 4> FailingCommands;
-  C.ExecuteJobs(C.getJobs(), FailingCommands);
+  C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
 
----------------
Why is StopOnFailure is false in this case? Shouldn't it obey command line options, too?


http://reviews.llvm.org/D16514