[PATCH] D16605: Implement `std::experimental::ostream_joiner`

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 27 17:39:33 PST 2016


EricWF added a comment.

One last thing. The spec implicitly defines the copy/move/assignment operators for "ostream_joiner" by making "_Delim" an exposition only member. Essentially "ostream_joiner" should only copy/moveable if "_Delim" is. I think we should add tests that ensure we actually follow this behavior.


================
Comment at: test/std/experimental/iterator/nothing_to_do.pass.cpp:2
@@ +1,3 @@
+//===----------------------------------------------------------------------===//
+//
+//                     The LLVM Compiler Infrastructure
----------------
Maybe call it "include_header.pass.cpp" then.


http://reviews.llvm.org/D16605





More information about the cfe-commits mailing list