[PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

Stephan Bergmann via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 27 08:50:26 PST 2016


sberg added inline comments.

================
Comment at: include/clang/AST/ASTConsumer.h:58-64
@@ -57,5 +57,9 @@
 
   /// \brief This callback is invoked each time an inline method definition is
   /// completed.
   virtual void HandleInlineMethodDefinition(CXXMethodDecl *D) {}
 
+  /// \brief This callback is invoked each time an inline friend function
+  /// definition is completed.
+  virtual void HandleInlineFriendFunctionDefinition(FunctionDecl *D) {}
+
----------------
rnk wrote:
> I'm pretty sure we can relax HandleInlineMethodDefinition to take a FunctionDecl and then we don't need the extra AST consumer callback.
...and then also rename it from HandleInlineMethodDefinition to, say,HandleInlineFunctionDefinition?  Or better stick with the (then no longer accurate) name?


http://reviews.llvm.org/D15267





More information about the cfe-commits mailing list