r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

[Ehsan Akhgari via cfe-commits]

Hi Renato,

Thanks, Nico helped me diagnose and fix the test yesterday <
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160125/147979.html>.
I fixed the test accordingly in r258776 and that seems to have worked!

Cheers,
Ehsan

On Tue, Jan 26, 2016 at 7:41 AM, Renato Golin <renato.golin at linaro.org>
wrote:

> Hi,
>
> So, the results I'm getting on that RUN list is:
>
> 1. clang -cake-is-lie etc.
>
> Runs ok, prints expected error messages, returns 1.
>
> 2. clang-cl -cake-is-lie
>
> I've hit an assert on
> llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp:80:
> llvm::MCCodeGenInfo* createAArch64MCCodeGenInfo(const llvm::Triple&,
> llvm::Reloc::Model, llvm::CodeModel::Model, llvm::CodeGenOpt::Level):
> Assertion `(TT.isOSBinFormatELF() || TT.isOSBinFormatMachO()) && "Only
> expect Darwin and ELF targets"' failed.
>
> Returns with error code 254, which is the one the bot was complaining
> about. Script attached.
>
> 3. Same, with -Werror=unknown-argument
>
> Runs ok, prints expected error messages, returns 1.
>
> 4. Same, with -Wno-unknown-argument
>
> Fails on "// SILENT-NOT: error", since Clang's -v output contains:
> "-ferror-limit 19". I think you'll have to be more specific there. I'm
> not sure how this passed anywhere.
>
> 5. Clang -S
>
> Get the expected warning, returns 0.
>
> Hope that helps.
>
> cheers,
> --renato
>



-- 
Ehsan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160126/67093bcc/attachment.html>