[PATCH] D16467: [libcxx] re.results.form: Format out-of-range subexpression references as null
Duncan P. N. Exon Smith via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 25 10:20:22 PST 2016
Given your follow-up review, and the behaviour of
match_results::operator[], do you still have reservations?
> On 2016-Jan-25, at 08:19, Marshall Clow <mclow.lists at gmail.com> wrote:
>
> mclow.lists added a comment.
>
> Not crashing is good; but silently returning a "wrong" answer rubs me the wrong way. I'll do some research and get back to you on this, but maybe throwing an exception is a better response.
>
> The code looks fine, though; I'm just not sure it's the right thing to do.
>
>
> http://reviews.llvm.org/D16467
>
>
>
More information about the cfe-commits
mailing list