[PATCH] D5023: [analyzer] Fix ObjC Dealloc Checker to operate only on classes with retained properties

[Devin Coughlin via cfe-commits]

dcoughlin updated this revision to Diff 45756.
dcoughlin marked 6 inline comments as done.
dcoughlin added a comment.

I've updated ddkilzer's patch to address Jordan's last round of comments.

Specifically, I have:

- Changed the patch to use isObjCRetainableType() to additional warn about properties of block type(and added a test).
- Added an assertion that a synthesized property implementation has a property declaration.
- Changed the patch to warn on readonly synthesized properties (and added tests).
- Changed the patch to not warn on weak properties.
- Removed tests for GC environments.
- Moved CHECK lines to be in-line with test code.


http://reviews.llvm.org/D5023

Files:
  lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
  test/Analysis/DeallocMissingRelease.m
  test/Analysis/MissingDealloc.m
  test/Analysis/PR2978.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5023.45756.patch
Type: text/x-patch
Size: 18238 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160122/7677d54e/attachment.bin>