[PATCH] D16295: Change of UserLabelPrefix default value from "_" to ""
Andrey Bokhanko via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 22 07:45:24 PST 2016
andreybokhanko added a comment.
Rafael, thanks for the review!
In http://reviews.llvm.org/D16295#329929, @rafael wrote:
> I am pretty sure the cases in init.c are wrong as the assembly itself
> doesn't use a '_'.
>
> Having said that, it is probably a good thing to do this in two steps.
> So this patch LGTM on the condition that you also open a bug to audit
> the cases where we define __USER_LABEL_PREFIX__ to _ in init.c and CC
> whoever added those.
Done. https://llvm.org/bugs/show_bug.cgi?id=26255
Yours,
Andrey
Repository:
rL LLVM
http://reviews.llvm.org/D16295
More information about the cfe-commits
mailing list