[PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 21 23:14:11 PST 2016


EricWF added a comment.

> - Did I successfully match the coding style? (I'm kind of lost without clang-format TBH.)


The style looks pretty good. I'll comment on any nits I have.

> - Should I separate the change to __construct_node_hash() into a separate prep commit? (I would if this were LLVM, but I'm not sure if the common practice is different for libc++.)


Yes please!


http://reviews.llvm.org/D16360





More information about the cfe-commits mailing list