[PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces
Samuel Benzaquen via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 20 13:37:00 PST 2016
sbenza added inline comments.
================
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:351
@@ +350,3 @@
+
+ // First, match the name.
+ if (!MatchNodeName(Pattern, Node))
----------------
klimek wrote:
> Perhaps comment that Pattern will be changed to the prefix, so it's clear afterwards.
> (I wonder whether returning a tuple might be slightly easier to understand here)
Renamed from Match to Consume. Is that better?
http://reviews.llvm.org/D15506
More information about the cfe-commits
mailing list