[PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

[Haojian Wu via cfe-commits]

hokein marked 3 inline comments as done.

================
Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.h:26
@@ +25,3 @@
+///   - `HeaderFileExtensions`: a comma-separated list of filename extensions of
+///     header files (no need to includ "."). "h" by default.
+///     For extension-less header files, using an empty string or leaving an
----------------
aaron.ballman wrote:
> s/includ/include
> 
> Is "." tolerated in the extension? It sounds like you can write: `h,.hpp,hxx` and it will work? Best to clarify the requirements (here and elsewhere). I don't have a strong opinion on whether the extension should include the full stop or not.
The "." is not tolerated in the extension. Having updated comments.

================
Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.h:28
@@ -22,1 +27,3 @@
+///     For extension-less header files, using an empty string or leaving an
+///     empty string between "," if there are other file extensions.
 class GlobalNamesInHeadersCheck : public ClangTidyCheck {
----------------
aaron.ballman wrote:
> What if you only want to match extensionless header files?
As the comment states, using an empty string "" only match extension-less header files.


http://reviews.llvm.org/D16113