[PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

[Paul Robinson via cfe-commits]

probinson added a comment.

I don't feel comfortable enough with Clang to review the code part.
The tests are generally good (one inline comment) but it seems like they could be done all in one test file, which is more efficient in terms of test run time.


================
Comment at: test/CodeGenCXX/debug-info-lb-static2.cpp:13
@@ +12,3 @@
+// CHECK: [[FuncScope:![0-9]+]] = distinct !DISubprogram(name: "main",
+// CHECK: !{{[0-9]+}} = !DIGlobalVariable(name: "X", scope: [[FuncScope:![0-9]+]],
+// CHECK: !{{[0-9]+}} = !DIGlobalVariable(name: "X", scope: [[LBScope:![0-9]+]],
----------------
I think the second check wants to end with `scope: [[FuncScope]],` (as written I think it's just redefining FuncScope).


http://reviews.llvm.org/D15977