r257868 - PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin

[Aaron Ballman via cfe-commits]

On Fri, Jan 15, 2016 at 11:55 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
> On Fri, Jan 15, 2016 at 11:52 AM, Hans Wennborg via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>> Should this be merged to 3.8?
>
> I can't speak to whether it severe enough to warrant it, but I think
> that it is sufficiently safe to merge.

I lied. This caused some regressions in practice, so it should not be
merged into 3.8.

~Aaron

>
> ~Aaron
>
>>
>> On Thu, Jan 14, 2016 at 8:36 PM, Alexey Bataev via cfe-commits
>> <cfe-commits at lists.llvm.org> wrote:
>>> Author: abataev
>>> Date: Thu Jan 14 22:36:32 2016
>>> New Revision: 257868
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=257868&view=rev
>>> Log:
>>> PR26111: segmentation fault with __attribute__((mode(QI))) on function declaration, by Denis Zobnin
>>> Allow "mode" attribute to be applied to VarDecl, not ValueDecl (which includes FunctionDecl and EnumConstantDecl), emit an error if this attribute is used with function declarations and enum constants.
>>> Differential Revision: http://reviews.llvm.org/D16112
>>>
>>> Modified:
>>>     cfe/trunk/include/clang/AST/Decl.h
>>>     cfe/trunk/include/clang/Basic/Attr.td
>>>     cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
>>>     cfe/trunk/lib/Sema/SemaDeclAttr.cpp
>>>     cfe/trunk/test/Sema/attr-mode.c
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits