[PATCH] D16278: ASTMatcher for ParenExpr node.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 19 06:31:01 PST 2016


aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.

I have a few small nits that don't require additional review.


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1052
@@ +1051,3 @@
+/// \brief Matches parentheses used in expressions.
+//
+// Example matches (foo() + 1)
----------------
Please use doxygen-style comments for the entire comment block.

================
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:3570
@@ +3569,3 @@
+  EXPECT_FALSE(matches("int i = 3;", parenExpr()));
+  EXPECT_FALSE(matches("int foo() { return 1; }; int a = foo();", parenExpr()));
+}
----------------
Please change this to EXPECT_TRUE and notMatches instead (for consistency in the rest of the file).


http://reviews.llvm.org/D16278





More information about the cfe-commits mailing list