[PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0
Anastasia Stulova via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 18 06:15:13 PST 2016
Anastasia added inline comments.
================
Comment at: lib/Sema/SemaDecl.cpp:7255
@@ -7209,3 +7254,3 @@
return PtrPtrKernelParam;
- return PointeeType.getAddressSpace() == 0 ? PrivatePtrKernelParam
- : PtrKernelParam;
+ // Now generice address space is added, we need to handle like this
+ unsigned addrSpace = PointeeType.getAddressSpace();
----------------
I think this should be removed?
================
Comment at: lib/Sema/SemaDecl.cpp:7279
@@ -7228,1 +7278,3 @@
+ if (PT->isReserveIDT())
+ return InvalidKernelParam;
----------------
Is there a test for this?
http://reviews.llvm.org/D16047
More information about the cfe-commits
mailing list