[PATCH] D16280: [OpenMP] Detect implicit map type to report unspecified map type for target enter/exit data directives.
Alexey Bataev via cfe-commits
cfe-commits at lists.llvm.org
Sun Jan 17 21:30:14 PST 2016
ABataev added inline comments.
================
Comment at: lib/Sema/SemaOpenMP.cpp:8587
@@ -8583,4 +8586,3 @@
Diag(StartLoc, diag::err_omp_invalid_map_type_for_directive) <<
- // TODO: Need to determine if map type is implicitly determined
- (0) <<
+ static_cast<unsigned>(IsMapTypeImplicit) <<
getOpenMPSimpleClauseTypeName(OMPC_map, MapType) <<
----------------
Do not cast bool to unsigned, use (IsMapTypeImplicit ? 1 : 0) instead
================
Comment at: lib/Sema/SemaOpenMP.cpp:8603
@@ -8600,4 +8602,3 @@
Diag(StartLoc, diag::err_omp_invalid_map_type_for_directive) <<
- // TODO: Need to determine if map type is implicitly determined
- (0) <<
+ static_cast<unsigned>(IsMapTypeImplicit) <<
getOpenMPSimpleClauseTypeName(OMPC_map, MapType) <<
----------------
The same
http://reviews.llvm.org/D16280
More information about the cfe-commits
mailing list