[PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

[Louis Dionne via cfe-commits]

ldionne updated this revision to Diff 44907.
ldionne marked 4 inline comments as done.
ldionne added a comment.

Address Richard Smith's review comments:

- Remove IndexType parameter, and make Index a std::size_t
- Remove assertion about APSInt::GetExtValue()
- Other style changes

Still left to do:

- Settle on a name for __nth_element
- Should we produce a diagnostic when the index is out of bounds, or is this reserved for standard-mandated diagnostics (and we should use another mean to report the error)?


http://reviews.llvm.org/D15421

Files:
  include/clang/AST/ASTContext.h
  include/clang/AST/DeclTemplate.h
  include/clang/Basic/Builtins.h
  include/clang/Basic/DiagnosticSemaKinds.td
  include/clang/Serialization/ASTBitCodes.h
  lib/AST/ASTContext.cpp
  lib/AST/DeclTemplate.cpp
  lib/Lex/PPMacroExpansion.cpp
  lib/Sema/SemaLookup.cpp
  lib/Sema/SemaTemplate.cpp
  lib/Serialization/ASTReader.cpp
  lib/Serialization/ASTWriter.cpp
  test/PCH/nth-element.cpp
  test/SemaCXX/nth_element.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15421.44907.patch
Type: text/x-patch
Size: 14344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160114/684a9a26/attachment-0001.bin>